Skip to content

feat: add /screenshot command for PR visual review - #122

Merged
jessepollak merged 2 commits into
mainfrom
feat/pr-screenshot-command
Sep 2, 2026
Merged

feat: add /screenshot command for PR visual review#122
jessepollak merged 2 commits into
mainfrom
feat/pr-screenshot-command

Conversation

@jessepollak

@jessepollak jessepollak commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Add .claude/commands/screenshot.md: a /screenshot slash command that captures the routes affected by a PR's diff with agent-browser and uploads them as GitHub prerelease assets for embedding in the PR body — the flow already used on bdocs, adapted to this repo's route tree (including the dev:internal requirement for the internal-explorer/benchmark surfaces) and to this repo being public: draft-release assets 404 for GitHub's anonymous Camo image proxy, so uploads are published prereleases (not marked latest), deleted with their tag after merge.
  • Add .github/PULL_REQUEST_TEMPLATE.md with a Screenshots section the command feeds.
  • Wire the requirement into AGENTS.md's "Pull requests" section so visual diffs (app/**, globals.css, tailwind.config.ts) get screenshots by default.
  • Gitignore the local screenshots/ staging directory.

Screenshots

Example output of running /screenshot on this repo (homepage at 1280×800, uploaded via screenshots-pr-122 prerelease):

home

Test plan

  • Verified the agent-browser open/wait/set/screenshot/close sequence used in the command against the local dev server — the embedded image above is its output.
  • Verified the prerelease asset URL returns 200 unauthenticated (a draft's URL returned 404, which is why the command publishes instead of drafting).
  • Run /screenshot on a real visual-change PR to confirm the route-mapping table holds up.

Adds a slash command that captures affected routes with agent-browser
and uploads them as draft GitHub release assets for embedding in PR
descriptions, mirroring the flow already in use on bdocs. Wires it into
the Pull requests section of AGENTS.md so visual diffs get screenshots
by default.

Co-Authored-By: Claude <noreply@anthropic.com>
@cb-heimdall

cb-heimdall commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel

vercel Bot commented Sep 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
omni-ui Ready Ready Preview Sep 2, 2026 5:31pm UTC

Request Review

Draft-release assets 404 for anonymous fetches, and GitHub's Camo image
proxy fetches anonymously — on this public repo embedded draft assets
render broken. Switch /screenshot to published prereleases (not marked
latest) and clean up the tag on delete. Add .github/PULL_REQUEST_TEMPLATE.md
with the Screenshots section the command feeds, and gitignore the local
screenshots/ staging dir.

Co-Authored-By: Claude <noreply@anthropic.com>
@jessepollak
jessepollak added this pull request to the merge queue Sep 2, 2026
Merged via the queue into main with commit f3a1059 Sep 2, 2026
13 checks passed
@jessepollak
jessepollak deleted the feat/pr-screenshot-command branch September 2, 2026 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants